This repository was archived by the owner on Oct 30, 2023. It is now read-only.
Open
Conversation
Owner
|
I'm down with accepting this, but can you add a new test that tests this syntax? |
|
btw - this PR fixes another issue - it would be great if it could be merged in and CPAN updated... Here's some markdown that demonstrates the bug... 1. Line 1 1. Line 2 1. Line 3 with code block ``` line 1 line 2 ``` 1. Line 4 with code block ``` a line a line after a blank line ``` 1. Line 5 The bug renders the blocks as 'code' and fails to detect the block on line 4: ...with patch... |
|
Mostly works, but it appears to be double-processing code inside the fences. I.e. Generates strange output given the following markdown: Output: Expected: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


https://help.github.com/articles/github-flavored-markdown/#fenced-code-blocks
I think this would be a handy feature, but I understand if you don't want to poison the implementation with Markdown dialects.
I modified sub _DoCodeBlocks to do two passes. First it tries to find any fenced code blocks using code adapted from sub _DoCodeSpans, hashes them, then proceeds to perform the traditional codeblock check. I did not write any new tests, but it continues to pass existing ones.