Use io.ReadFull for reading decompressed tls data#7
Open
albinstman wants to merge 1 commit intobogdanfinn:masterfrom
Open
Use io.ReadFull for reading decompressed tls data#7albinstman wants to merge 1 commit intobogdanfinn:masterfrom
albinstman wants to merge 1 commit intobogdanfinn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it only reads partially from the buffer. In some cases it can return fewer bytes which corrupts the tls handshake.
For me it ends up with "ECDSA signature verification error" because the public key parsed from the malformed certificate doesn't match the server's actual key. But the fix is just to read the buffer in full so we don't end up with a malformed cert.
Encountered error when using profiles.Safari_IOS_17_0 on example.com (should be any profile advertising and using compression)