minor improvement and a bug fix#7
Open
vinxxe wants to merge 4 commits intobogdanm:masterfrom
Open
Conversation
added 4 commits
May 2, 2023 14:31
- added python3 compatibility - added --include-path option - used floor division (//) to compute ABS32 symbol offset
the asm template has been changed to load into the r1 register (to jump to udynlink_get_lot_base address) the value of the defined label. then the user shall call the function udynlink_patch_exported_func to write the address of udynlink_get_lot_base to the space reserved for the label. the only thing that shall be known at compile time is the code length in bytes of the asm prologue. the rodata has been moved to the data section because the udynlink_patch_exported_func patch the global symbols belonging to the text section
…e global symbols of the last file only. this fix resolves this problem. now the script saves the global symbols of all the object files and, in the linking phase, it makes all these symbols local.
just in case you need to compile without thumb instruction set
|
Thank you very much, this is good! 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I made a few changes and maybe you are interested in some of them.
thank you for your great work
vinx