Merged
Conversation
hannesdejager
force-pushed
the
spi
branch
5 times, most recently
from
a1db526 to
16194d3
Compare
robklg
reviewed
Feb 13, 2026
robklg
approved these changes
Feb 13, 2026
hannesdejager
force-pushed
the
spi
branch
2 times, most recently
from
069a9df to
e960f75
Compare
This split moves the backend-facing API surface into a dedicated crate such that unftp-sbe-* and unftp-auth-* back-ends/plugins/extentions only depend on this new crate called `unftp-core`. The name reflects its role as the common dependency and contract for libunftp and all backend implementations, while avoiding lib* or Java-ish SPI-style naming that is uncommon in the Rust ecosystem. This keeps the public surface clear, idiomatic, and consistent with existing unftp-* crates. Why this change: - Backends shouldn’t force libunftp feature flags or crypto provider choices which was becoming awkward. - A stable interface crate lets backends evolve independently of server internals i.e. back-ends don't need to go to a new version if some server implementation bug was fixed. - Smaller dependency graphs for backends reduce compile times and rebuild scope What I did: - Introduced the `unftp-core` crate with auth/storage traits, errors, and helper types - Switched auth and storage backends to depend on `unftp-core`. - Updated examples and docs to use `ServerBuilder` instead of `ServerExt` - `ServerExt` unfortunately had to go cause it caused a dependency for back-ends on libunftp again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This split moves the backend-facing API surface into a dedicated crate such that unftp-sbe-* and unftp-auth-* back-ends/plugins/extentions only depend on this new crate called
unftp-core.The name reflects its role as the common dependency and contract for libunftp and all backend implementations, while avoiding lib* or Java-ish SPI-style naming that is uncommon in the Rust ecosystem. This keeps the public surface clear, idiomatic, and consistent with existing unftp-* crates.
Why this change:
What I did:
unftp-corecrate with auth/storage traits, errors, and helper typesunftp-coreServerBuilderinstead ofServerExt-ServerExtunfortunately had to go cause it caused a dependency for back-ends on libunftp again.