Skip to content

sync(bfmono): feat(gambit): add explicit codex skip-sandbox yolo mode (+19 more) (bfmono@9ce3921c5) #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bft-codebot merged 1 commit into from
Mar 22, 2026
Merged

sync(bfmono): feat(gambit): add explicit codex skip-sandbox yolo mode (+19 more) (bfmono@9ce3921c5) #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/providers/codex.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,7 @@ Deno.test("codex provider skips sandbox config when yolo env is enabled", () =>
cwd: "/tmp/test-cwd",
});
const joined = args.join(" ");
assertEquals(joined.includes("--yolo"), true);
assertEquals(joined.includes('approval_policy="never"'), true);
assertEquals(joined.includes('sandbox_mode="workspace-write"'), false);
assertEquals(
Expand All @@ -921,6 +922,27 @@ Deno.test("codex provider skips sandbox config when yolo env is enabled", () =>
}
});

Deno.test("codex provider skips sandbox config when additionalParams.codex.skip_sandbox_config is true", () => {
const args = parseCodexArgsForTest({
model: "codex-cli/default",
messages: [{ role: "user", content: "hi" }],
cwd: "/tmp/test-cwd",
params: {
codex: {
skip_sandbox_config: true,
},
},
});
const joined = args.join(" ");
assertEquals(joined.includes("--yolo"), true);
assertEquals(joined.includes('approval_policy="never"'), true);
assertEquals(joined.includes('sandbox_mode="workspace-write"'), false);
assertEquals(
joined.includes("sandbox_workspace_write.writable_roots"),
false,
);
});

Deno.test("codex provider omits MCP root deck env when deck path is absent", () => {
const args = parseCodexArgsForTest({
model: "codex-cli/default",
Expand Down
13 changes: 13 additions & 0 deletions src/providers/codex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ function shouldSkipCodexSandboxConfig(
): boolean {
const yolo = params?.gambitYolo;
if (typeof yolo === "boolean") return yolo;
const codex = asRecord(params?.codex);
const codexSkipSandboxConfig = codex.skip_sandbox_config;
if (typeof codexSkipSandboxConfig === "boolean") {
return codexSkipSandboxConfig;
}
const envRaw = Deno.env.get(CODEX_SKIP_SANDBOX_CONFIG_ENV);
return Boolean(envRaw && parseTruthy(envRaw));
}
Expand Down Expand Up @@ -1154,6 +1159,7 @@ export function createCodexProvider(opts?: {
priorThreadId,
});
const cwd = runCwd();
const skipSandboxConfig = shouldSkipCodexSandboxConfig(input.params);
const args = priorThreadId
? [
"exec",
Expand All @@ -1162,6 +1168,9 @@ export function createCodexProvider(opts?: {
"--json",
]
: ["exec", "--skip-git-repo-check", "--json"];
if (skipSandboxConfig) {
args.push("--yolo");
}
args.push(
...codexConfigArgs({
cwd,
Expand Down Expand Up @@ -1410,9 +1419,13 @@ export function parseCodexArgsForTest(input: {
messages: input.messages,
priorThreadId,
});
const skipSandboxConfig = shouldSkipCodexSandboxConfig(input.params);
const args = priorThreadId
? ["exec", "resume", "--skip-git-repo-check", "--json"]
: ["exec", "--skip-git-repo-check", "--json"];
if (skipSandboxConfig) {
args.push("--yolo");
}
args.push(
...codexConfigArgs({
cwd: input.cwd ?? runCwd(),
Expand Down
Loading