Merged
Conversation
thomasnemer
force-pushed
the
134-trim-spaces-folder-names
branch
from
8b98cc6 to
7b327dd
Compare
thomasnemer
added
the
ready-for-tests
Add .trim() after truncating filename in sanitize_filename to ensure folder names don't have trailing spaces from truncation. Fixes #134
thomasnemer
force-pushed
the
134-trim-spaces-folder-names
branch
from
7b327dd to
65c7546
Compare
thomasnemer
added
ready-for-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added
.trim().to_string()to the folder name creation inget_activity_folderfunction to prevent folder names from having leading or trailing whitespace.Test plan
Fixes #134