Skip to content

Accept signed int32 colors in validator #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowboyd merged 2 commits into from
Apr 8, 2026
Merged

Accept signed int32 colors in validator #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7602722
🐛 accept signed int32 colors in validator
cowboyd Apr 8, 2026
92577d4
🐛 accept signed int32 colors in validator
cowboyd Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ import type { RenderOptions, RenderResult, Term } from "./term.ts";

const u8 = Type.Integer({ minimum: 0, maximum: 255 });
const u16 = Type.Integer({ minimum: 0, maximum: 65535 });
const u32 = Type.Integer({ minimum: 0, maximum: 0xFFFFFFFF });

/* RGBA color packed as (a << 24 | r << 16 | g << 8 | b). When alpha >= 128,
* bit 31 is set and JavaScript interprets the value as a negative int32.
* Accept both signed and unsigned representations of the same bit pattern. */
const rgba = Type.Integer({ minimum: -0x80000000, maximum: 0xFFFFFFFF });

/* ── Sizing axis (discriminated union) ────────────────────────────── */

Expand Down Expand Up @@ -64,7 +68,7 @@ const CornerRadius = Type.Object({
});

const Border = Type.Object({
color: u32,
color: rgba,
left: Type.Optional(u8),
right: Type.Optional(u8),
top: Type.Optional(u8),
Expand Down Expand Up @@ -93,7 +97,7 @@ const OpenElement = Type.Object({
id: Type.Literal(0x02),
name: Type.String(),
layout: Type.Optional(Layout),
bg: Type.Optional(u32),
bg: Type.Optional(rgba),
cornerRadius: Type.Optional(CornerRadius),
border: Type.Optional(Border),
clip: Type.Optional(Clip),
Expand All @@ -103,7 +107,7 @@ const OpenElement = Type.Object({
const TextOp = Type.Object({
id: Type.Literal(0x03),
content: Type.String(),
color: Type.Optional(u32),
color: Type.Optional(rgba),
fontSize: Type.Optional(u8),
fontId: Type.Optional(u8),
wrap: Type.Optional(u8),
Expand Down
Loading