Inline WASM binary into generated TypeScript module#9
Merged
Conversation
commit: |
cowboyd
force-pushed
the
inline-wasm
branch
3 times, most recently
from
3d2d339 to
24febec
Compare
Replace runtime filesystem read of clayterm.wasm with a build step that base64-encodes the binary into wasm.ts. This removes the node:fs/promises dependency and --allow-read requirement for the WASM file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clayterm.wasmwith a build step that base64-encodes the binary intowasm.tsnode:fs/promisesdependency and--allow-readpermission requirementfile://URLs (esm.sh,deno compilebinaries)Test plan
makebuilds WASM and generateswasm.ts--allow-readfor the WASM filewasm.tsis gitignored as a build artifact