Fix/komga api improvements#2524
Closed
farfromrefug wants to merge 5 commits intobooklore-app:developfrom
Closed
Conversation
Collaborator
|
@farfromrefug Hi, thanks for the PR! I’m a bit busy right now and don’t have time to test the full flow. Would you be able to coordinate with some testers to confirm that everything works as it should? Thanks. |
Contributor
Author
|
@CORAAL @stefanop1 would it be possible fo you guys to test that PR ? |
Of course, no problem. |
|
I ran the test on 3 applications:
From Booklore, I enabled OPDS and the Komga API, then configured an OPDS user. I used four different works: three in CBZ format and one in CBR format. Each book was stored in a single library. Connection
Note Each work from the library appears.
Warning The Komelia application returns an error after about one minute:
ReadingKoma
Komikku
Komelia ❌
Komelia with Manga1.cbr and Webtoon1.cbz returns the same error: |
Contributor
Author
|
@CORAAL awesome tests! Also it may appear like Komelia works but if you go into a "series" you won't see the correct books. This is because Komelia use that complex POST API that i did not ported. Not sure it is worth the effort. About the errors, it is true i only work with CBZ having a ComicInfo.xml. This is an issue with booklore where pageCount is not computed if not part of ComicInfo.xml. Thus it will make all the clients fails. @acx10 any thought about this? |
|
@farfromrefug |
|
need some test? |
Contributor
Author
|
@beudbeud not yet. The tricky part is the merging. Too many things have changed in the repo. Getting tricky to follow. |
…provements # Conflicts: # booklore-api/src/main/java/com/adityachandel/booklore/config/WebMvcConfig.java # booklore-api/src/main/java/org/booklore/config/KomgaCleanBeanPropertyWriter.java # booklore-api/src/main/java/org/booklore/config/security/SecurityConfig.java # booklore-api/src/main/java/org/booklore/controller/KomgaController.java # booklore-api/src/main/java/org/booklore/mapper/komga/KomgaMapper.java # booklore-api/src/main/java/org/booklore/service/appsettings/AppSettingService.java # booklore-api/src/main/java/org/booklore/service/komga/KomgaService.java # booklore-api/src/test/java/org/booklore/service/komga/KomgaServiceTest.java
Contributor
Author
|
@acx10 i have updated my PR but i have some issues after that. in KomgaService, metadata is always null. It was working before i merged from develop. |
Collaborator
@farfromrefug Could this be a hibernate issue? Do you see anything suspicious in the backend logs? |
Contributor
Author
|
@acx10 no i dont see anything "special" in the logs. |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📝 Description
This PR improves the Komga API for use with Mihon/Komikku/Koma/Komelia
That PR has no sideeffect in the rest of booklore
🛠️ Changes Implemented
Komelia is not yet fully working because it relies on a complex POST API to request from the db with the
conditionparameter here https://komga.org/docs/openapi/get-series.Implementing would be pretty complex. We could directly copy the code from Komga but i am not sure this is something we want
🧪 Testing Strategy
📸 Visual Changes (if applicable)
Please Read - This Checklist is Mandatory
Mandatory Requirements (please check ALL boxes):
developbranch (please resolve any merge conflicts)./gradlew testfor Spring Boot backend, andng testfor Angular frontend - NO EXCEPTIONS)Why This Matters:
Recent production incidents have been traced back to:
Backend changes without tests will not be accepted. By completing this checklist thoroughly, you're helping maintain the quality and stability of Booklore for all users.
Note to Reviewers: Please verify the checklist is complete before beginning your review. If items are unchecked, kindly ask the contributor to complete them first.
💬 Additional Context (optional)