Skip to content

fix: remove unused arguments - #552

Open
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/unused-main-args
Open

fix: remove unused arguments#552
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/unused-main-args

Conversation

@Becheler

@Becheler Becheler commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

#496

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

Numerous examples and test files int main( have unused arguments.

Motivation

Way too many warnings with -Wextra -Wall

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@Becheler Becheler self-assigned this Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 31246275249 vs develop run 31207793080 (46ad50e8b2).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 68 → 68 (0)

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 31246275246 vs develop run 31207793516 (46ad50e8b2).

Job Baseline After Delta
macos (clang, 14) 681 604 -77
macos (clang, 17) 641 564 -77
macos (clang, 20) 641 564 -77
ubuntu (clang-19, 14) 681 604 -77
ubuntu (clang-19, 17) 641 564 -77
ubuntu (clang-19, 20) 641 564 -77
ubuntu (clang-19, 23) 641 564 -77
ubuntu (gcc-14, 14) 827 750 -77
ubuntu (gcc-14, 17) 949 872 -77
ubuntu (gcc-14, 20) 949 872 -77
ubuntu (gcc-14, 23) 949 872 -77
windows_msvc_14_3 (msvc-14.3) 971 971 0

@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.44%. Comparing base (e8e3f01) to head (46ad50e).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #552      +/-   ##
===========================================
- Coverage    92.45%   92.44%   -0.02%     
===========================================
  Files          392      392              
  Lines        28214    28214              
  Branches      8008     8008              
===========================================
- Hits         26086    26083       -3     
- Misses        2024     2026       +2     
- Partials       104      105       +1     
Files with missing lines Coverage Δ
example/astar-cities.cpp 95.78% <100.00%> (ø)
example/bipartite_example.cpp 100.00% <100.00%> (ø)
example/canonical_ordering.cpp 94.11% <100.00%> (ø)
example/cycle_ratio_example.cpp 100.00% <100.00%> (ø)
example/grid_graph_example.cpp 96.87% <100.00%> (ø)
example/grid_graph_properties.cpp 100.00% <100.00%> (ø)
example/incremental-components-eg.cpp 100.00% <100.00%> (ø)
example/incremental_components.cpp 100.00% <100.00%> (ø)
example/kuratowski_subgraph.cpp 92.10% <100.00%> (ø)
example/make_biconnected_planar.cpp 92.85% <100.00%> (ø)
... and 17 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8dc81...46ad50e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler
Becheler marked this pull request as ready for review August 8, 2026 08:40
@Becheler
Becheler requested a review from jeremy-murphy as a code owner August 8, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant