Skip to content

[bug] Fix severe performance bug caused by usage of float #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquintides merged 5 commits into from
Apr 24, 2026
Merged

[bug] Fix severe performance bug caused by usage of float #94

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
816fbc5
Replace `float` with `double` in hashed_index.hpp
Mar 14, 2026
8ba5327
Fix formatting indents
Apr 11, 2026
d4e2872
Reset changes
Apr 23, 2026
270b3d6
Add fix from PR comment
Apr 23, 2026
dfad530
forced both args of std::max to the same type
joaquintides Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions include/boost/multi_index/hashed_index.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Copyright 2003-2025 Joaquin M Lopez Munoz.
/* Copyright 2003-2026 Joaquin M Lopez Munoz.
* Distributed under the Boost Software License, Version 1.0.
* (See accompanying file LICENSE_1_0.txt or copy at
* http://www.boost.org/LICENSE_1_0.txt)
Expand Down Expand Up @@ -1432,7 +1432,11 @@ class hashed_index:protected SuperMeta::type
if(n>max_load){
size_type bc =(std::numeric_limits<size_type>::max)();
float fbc=1.0f+static_cast<float>(n)/mlf;
if(bc>fbc)bc =static_cast<size_type>(fbc);
if(bc>fbc){
bc =(std::max)(
static_cast<size_type>(fbc),
static_cast<size_type>(bucket_count()+1));
}
unchecked_rehash(bc);
}
}
Expand Down
Loading