Draft
Conversation
|
Hello, |
Collaborator
Author
|
Please do go ahead and use this and report back: we need to revisit this now that latest GCC supports std::format and finish this support off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tentative first step towards supporting C++20's std::format.
Integers are all working and feature complete other than the usual undiscovered bugs and corner cases.
Other number types will require some refactoring of the code in format.hpp, though exactly how/what remains to be seen.
This also ties in with #297 as it adds binary string formatting.
Currently only latest msvc supports
<format>, for gcc we will have to wait for gcc-13 later in the year, likewise clang/libc++.Comments welcome as always.