spec: Use ExclusiveArch for supported architectures#221
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the packit configuration to restrict Fedora builds to supported architectures (x86_64, aarch64) by using ExclusiveArch. No security vulnerabilities were found. However, a potential issue with the verification step was identified that could lead to incorrect builds if the substitution fails. Suggestions have been provided to make the verification more robust and to simplify commands by removing redundant bash -c wrappers.
cgwalters
previously approved these changes
Mar 9, 2026
gursewak1997
force-pushed
the
add-packit-arch-patch
branch
2 times, most recently
from
93f23d9 to
899bdef
Compare
Only build RPM packages for x86_64 and aarch64, which are the architectures with full support and testing. This prevents build failures on ppc64le/s390x where the unit tests fail. This doesn't block developers from building with cargo on any architecture for local experimentation. Signed-off-by: gursewak1997 <gursmangat@gmail.com>
gursewak1997
force-pushed
the
add-packit-arch-patch
branch
from
899bdef to
7bacc1c
Compare
gursewak1997
changed the title
cgwalters
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only build RPM packages for x86_64 and aarch64, which are the architectures with full support and testing. This prevents build failures on ppc64le/s390x where the unit tests fail. This doesn't block developers from building with cargo on any architecture for local experimentation.