Skip to content

ephemeral: Add a few more tips to --help#257

Merged
gursewak1997 merged 1 commit intobootc-dev:mainfrom
cgwalters:more-help
May 6, 2026
Merged

ephemeral: Add a few more tips to --help#257
gursewak1997 merged 1 commit intobootc-dev:mainfrom
cgwalters:more-help

Conversation

@cgwalters
Copy link
Copy Markdown
Collaborator

Followup to previous commit.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the documentation for ephemeral VM operations by introducing structured sections and adding examples for local container images and disk image inspection. Feedback was provided to correct the disk inspection example, specifically regarding Rust string literal escaping and the necessity of mounting specific partitions rather than the raw disk device.

Comment thread crates/kit/src/ephemeral.rs Outdated
Comment thread crates/kit/src/ephemeral.rs Outdated
gursewak1997
gursewak1997 previously approved these changes May 5, 2026
Copy link
Copy Markdown
Collaborator

@gursewak1997 gursewak1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though

Followup to previous commit.

Signed-off-by: Colin Walters <walters@verbum.org>
@gursewak1997 gursewak1997 enabled auto-merge (squash) May 6, 2026 00:40
@gursewak1997 gursewak1997 merged commit 1685dc7 into bootc-dev:main May 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants