Skip to content

deploy: fix progress bar math for containers-storage transport #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gursewak1997 merged 1 commit into from
Mar 13, 2026
Merged

deploy: fix progress bar math for containers-storage transport #2067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/lib/src/deploy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,15 @@ async fn handle_layer_progress_print(mut config: LayerProgressConfig) -> Progres
bytes_total: layer_size,
};
} else {
byte_bar.set_position(layer_size);
// Use the bar's length (actual blob size) rather than
// the manifest descriptor size for completion accounting.
let actual_size = byte_bar.length().unwrap_or(layer_size);
byte_bar.set_position(actual_size);
layers_bar.inc(1);
total_read = total_read.saturating_add(layer_size);
total_read = total_read.saturating_add(actual_size);
// Emit an event where bytes == total to signal completion.
subtask.bytes = layer_size;
subtask.bytes_total = actual_size;
subtask.bytes = actual_size;
subtasks.push(subtask.clone());
config.prog.send(Event::ProgressBytes {
task: "pulling".into(),
Expand Down Expand Up @@ -268,7 +272,12 @@ async fn handle_layer_progress_print(mut config: LayerProgressConfig) -> Progres
bytes.as_ref().cloned()
};
if let Some(bytes) = bytes {
// Update the bar length from the actual blob size, which
// may differ from the manifest descriptor size (e.g.
// containers-storage stores layers uncompressed).
byte_bar.set_length(bytes.total);
byte_bar.set_position(bytes.fetched);
subtask.bytes_total = bytes.total;
subtask.bytes = byte_bar.position();
config.prog.send_lossy(Event::ProgressBytes {
task: "pulling".into(),
Expand Down
Loading