Sync common files from infra repository#129
Merged
Conversation
bootc-bot
bot
force-pushed
the
sync-common-files
branch
from
f5acf96 to
8716824
Compare
Synchronized from bootc-dev/infra@eb09fd5. Signed-off-by: bootc-dev Bot <bot@bootc.dev>
bootc-bot
bot
force-pushed
the
sync-common-files
branch
from
8716824 to
58da14c
Compare
Adding new fields to a publicly constructible struct is a semver breaking change. Mark the struct as #[non_exhaustive] so that future field additions are compatible, requiring users to use `..Default::default()` when constructing the struct. Fixes cargo-semver-checks failure from the insecure_policy field addition. Assisted-by: Claude Code (Opus 4.5) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Contributor
|
Hi @cgwalters , PR #127 added API break change. I think CI is right, adding |
Collaborator
|
Hm #127 doesn't add |
Collaborator
|
Oh wait I see it's in this PR?? Wat. |
Collaborator
|
Yes what happened is I merged #127 not noticing the semver check failed (because it's not gating) and @henrywang pushed an update to this PR on top of what renovate did - why did you do that instead of a separate PR? |
Collaborator
|
Ah ok I see it now, makes sense. I thought the sync action added that which thoroughly confused me. |
cgwalters
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by GitHub workflow (source).
This PR synchronizes common files from the infra repository.
Synchronized from bootc-dev/infra@eb09fd5.