Sync lint config and CI with bootc-dev conventions#130
Open
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Open
Sync lint config and CI with bootc-dev conventions#130cgwalters wants to merge 1 commit intobootc-dev:mainfrom
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Conversation
Basically just trying to reduce CI drift. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request synchronizes linting configurations and CI scripts with conventions from bootc-dev. The changes include adding a [lints] section to Cargo.toml to enforce stricter code quality rules, introducing a Justfile for standardized build/test/lint commands, and updating the code to comply with the new linting rules. Specifically, examples/client.rs was updated to use the idiomatic into_config naming, and src/imageproxy.rs was adjusted to handle a necessary unsafe block correctly under the new unsafe_code = "deny" rule. My review found the changes to be of high quality. I have one minor suggestion for improvement in the newly added Justfile to remove a redundant flag.
henrywang
approved these changes
Mar 5, 2026
Contributor
|
The |
henrywang
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically just trying to reduce CI drift.
Assisted-by: OpenCode (Claude claude-opus-4-6)