Skip to content

devcontainer: Switch to --privileged for Codespaces compatibility#136

Merged
cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters:devcontainer-priv
Mar 12, 2026
Merged

devcontainer: Switch to --privileged for Codespaces compatibility#136
cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters:devcontainer-priv

Conversation

@cgwalters
Copy link
Contributor

Replace fine-grained capability/security-opt arguments (--cap-add=all, label=disable, unmask=/proc/*, etc.) with --privileged for broad compatibility across Codespaces, Docker, and the stock devcontainer CLI.

Add the devaipod nestedContainers customization so that devaipod can apply a tighter security profile (SYS_ADMIN, NET_ADMIN, unmask=/proc/*, label=disable, seccomp=unconfined) instead of full --privileged when running under its control.

Also trigger the test-devcontainer CI workflow on .devcontainer/ changes.

Closes: #135

Assisted-by: OpenCode (Claude claude-opus-4-6)

@cgwalters cgwalters requested a review from ckyrouac March 12, 2026 14:50
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the devcontainer setup by consolidating complex security arguments into a single --privileged flag, significantly improving compatibility across various development platforms. It also introduces a mechanism for devaipod to enforce a more granular and secure environment when active, ensuring a balance between ease of use and security. Additionally, it enhances development workflow by enabling automated CI testing for devcontainer configuration changes.

Highlights

  • Simplified Security Configuration: Replaced detailed capability and security-option arguments (e.g., --cap-add=all, label=disable, unmask=/proc/*) with a single --privileged flag for broader compatibility across development environments like Codespaces, Docker, and the standard devcontainer CLI.
  • Enhanced devaipod Integration: Introduced a devaipod nestedContainers customization, allowing devaipod to apply a more restrictive security profile (e.g., SYS_ADMIN, NET_ADMIN, unmask=/proc/*, label=disable, seccomp=unconfined) when it manages the container, overriding the general --privileged setting.
  • CI Workflow Trigger: Configured the test-devcontainer CI workflow to activate automatically upon changes to files within the .devcontainer/ directory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • common/.devcontainer/devcontainer.json
    • Replaced a list of specific runArgs (including --cap-add=all, --security-opt, --device) with a single runArgs: ["--privileged"].
    • Added a privileged: true property to the root of the configuration.
    • Introduced a devaipod customization block with nestedContainers: true to allow for specific security overrides.
    • Corrected a typo in a comment from "Abitrary" to "Arbitrary".
    • Removed an extraneous trailing newline at the end of the file.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/test-devcontainer.yml
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request switches the devcontainer configuration to use privileged mode for better compatibility with Codespaces. While this may be necessary, it introduces a significant security risk by granting the container full access to the host. My review includes a critical comment highlighting this security concern. Additionally, I've pointed out a redundant configuration entry that can be removed.

Replace fine-grained capability/security-opt arguments (--cap-add=all,
label=disable, unmask=/proc/*, etc.) with --privileged for broad
compatibility across Codespaces, Docker, and the stock devcontainer CLI.

Add the devaipod nestedContainers customization so that devaipod can
apply a tighter security profile (SYS_ADMIN, NET_ADMIN, unmask=/proc/*,
label=disable, seccomp=unconfined) instead of full --privileged when
running under its control.

Also trigger the test-devcontainer CI workflow on .devcontainer/ changes.

Closes: bootc-dev#135

Assisted-by: OpenCode (Claude claude-opus-4-6)
Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters enabled auto-merge (squash) March 12, 2026 17:35
@cgwalters cgwalters merged commit eee9b69 into bootc-dev:main Mar 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix our devcontainers to work in codespaces again

2 participants