fix(tsforge): route app-feature env to compose api.${STACK}.env#225
Open
agjs wants to merge 1 commit into
Open
fix(tsforge): route app-feature env to compose api.${STACK}.env#225agjs wants to merge 1 commit into
agjs wants to merge 1 commit into
Conversation
The compose api service loads its env from infra/compose/compose/api.dev.env
(dev) / api.prod.env (prod) via docker-compose.yml `env_file`. apps/api/.env is
only read by standalone `bun run dev`, never by the compose stack the scaffold
wizard boots. Point envFileDefault at the compose api env file with a ${STACK}
placeholder the wizard resolves (smoke shares the dev file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #224. Corrects
envFileDefaultin.tsforge/scaffold-manifest.json.#224 routed app-feature vars (
EMAIL_PROVIDER,BILLING_ENABLED,AI_*, …) toapps/api/.env. Butdocker-compose.ymlloads the api container's env viaenv_file:api-dev→./api.dev.envapi→./api.prod.envapps/api/.envis read only by standalonebun run dev— never by the compose stack that the scaffold wizard actually boots (setup.sh --up→dev.sh up). So app-feature toggles set by the wizard would have landed in a file the running containers ignore.Fix
The wizard resolves the
${STACK}placeholder (dev→api.dev.env,prod→api.prod.env;smokeshares the dev file). Infra toggles (compose/.env) and identity/observability secrets were already routed correctly and are unchanged.Validated: manifest parses, zero coverage gaps, and edits now resolve to
api.dev.env/api.prod.envby stack.