binder: detect fixed-array args via isArray(), not dim.size()#196
Merged
Conversation
daslang PR GaijinEntertainment/daScript#3095 replaces TypeDecl's flattened dim/dimExpr vectors with a structural Type::tFixedArray — the dim member is gone. isArray() means "is a fixed-size array" in both worlds (dim.size() != 0 before, baseType == tFixedArray after), so this compiles and behaves identically against current daslang master and against the rework. Mergeable ahead of the daslang PR; unblocks its extended_checks, which installs dasImgui from master. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daslang PR GaijinEntertainment/daScript#3095 replaces
TypeDecl's flatteneddim/dimExprvectors with a structuralType::tFixedArray— thedimmember is gone, so the twoarg->type->dim.size() == 0reads in the ImVec2/ImVec4 const&→by-value fixup stop compiling.isArray()means "is a fixed-size array" in both worlds (dim.size() != 0on current daslang master,baseType == tFixedArrayafter the rework), so!arg->type->isArray()compiles and behaves identically against both.Merge order: this is mergeable ahead of the daslang PR — this repo's CI builds against current daslang master and is unaffected. Merging it unblocks daScript#3095's
extended_checks, which doesdaspkg install dasImgui --branch masterand currently fails withcb_dasIMGUI.h:164: no member named 'dim' in 'das::TypeDecl'.Verified locally: module builds clean against the rework branch (junctioned tree, full
_buildrebuild + daslang startup smoke loading the rebuilt.shared_module).🤖 Generated with Claude Code