recording: bar_groups_and_pie (categorical charts + legend toggle)#16
Merged
Conversation
First of the display-tour recordings. bar_groups_and_pie shows the two CATEGORICAL items side by side: a grouped bar chart (three series clustered into four quarters) and a pie chart (one slice per labelled value). The display tour carries one real interaction - a LEGEND TOGGLE on the grouped bars: clicking a series hides it across EVERY group at once (the whole `industrial` color drops out of all four quarters - distinct from hiding a single line series), then a second click restores it. Voiced and self-verifying with REAL synthetic input: the toggle must flip the series' `shown` flag both ways (wait_for_series_shown false then true) and both plots must render, so a no-op toggle or a missing chart aborts at teardown. - tests/integration/record_bar_groups_and_pie.das: the voiced driver (intro both charts + legend toggle hide/restore on the bars + point at the pie). - doc/source/tutorials/bar_groups_and_pie.rst: + .. video:: bar_groups_and_pie.mp4 and a Walkthrough section describing the across-all-groups legend toggle. - doc/source/_static/tutorials/bar_groups_and_pie.mp4: the recording (705 KB, 30.2s, 778 frames, 0 dropped, Emma voice + -16 dB bed). The headless guard is the existing test_bar_groups_and_pie.das. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds the first “display-tour” recording for the bar_groups_and_pie tutorial, including a self-verifying legend-toggle interaction on grouped bars, and updates the tutorial docs to embed and describe the walkthrough video.
Changes:
- Add a new integration recording driver (
record_bar_groups_and_pie.das) that narrates the two categorical charts and validates legend toggle hide/restore viawait_for_series_shown. - Document the new walkthrough in the tutorial RST and embed the corresponding video.
- Add the recorded tutorial video asset (
bar_groups_and_pie.mp4) under the docs static tutorials directory.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integration/record_bar_groups_and_pie.das | New voiced recording driver that exercises and verifies grouped-bar legend toggling plus pie rendering. |
| doc/source/tutorials/bar_groups_and_pie.rst | Adds a “Walkthrough” section embedding the video and describing the cross-group legend toggle behavior. |
| doc/source/_static/tutorials/bar_groups_and_pie.mp4 | Tutorial walkthrough video asset referenced by the new docs section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the display-tour recordings.
bar_groups_and_pieshows the two categorical items side by side: a grouped bar chart (three series clustered into four quarters) and a pie chart (one slice per labelled value). The tour carries one real interaction — a legend toggle on the grouped bars: clicking a series hides it across every group at once (the wholeindustrialcolor drops out of all four quarters — distinct from hiding a single line series in multi_series), then a second click restores it.Voiced and self-verifying with real synthetic input: the toggle must flip the series'
shownflag both ways (wait_for_series_shownfalse → true) and both plots must render, so a no-op toggle or a missing chart aborts at teardown.Files
tests/integration/record_bar_groups_and_pie.das— the voiced driver (intro both charts + legend toggle hide/restore on the bars + point at the pie).doc/source/tutorials/bar_groups_and_pie.rst—.. video:: bar_groups_and_pie.mp4+ a Walkthrough section describing the across-all-groups legend toggle.doc/source/_static/tutorials/bar_groups_and_pie.mp4— the recording (705 KB, 30.2 s, 778 frames, 0 dropped, Emma voice + −16 dB bed).Verification
ok:true, 778 frames, 0 dropped; all gates pass (both plots rendered +industrialshownflips false then true).The headless guard is the existing
test_bar_groups_and_pie.das.🤖 Generated with Claude Code