v1 parity: RAII scope wrappers for every Begin/End + Push/Pop pair

[borisbat]

Audit result

The thin v1 tier (imgui_implot_boost) exists to wrap the paired ImPlot APIs whose End/Pop can't be safely skipped — that's its whole value-add. Everything else (items like PlotText/PlotHeatmap/PlotBarGroups/DragPoint, SetNext* styling, SampleColormap, PlotToPixels, SetupAxis/SetupLegend) is already reachable raw via require implot public, so it needs no wrapper.

Auditing the binding for Begin*/End* + Push*/Pop* pairs, v1 already had with_plot and with_subplots; this fills in every remaining paired scope:

Wrapper	Native pair
with_aligned_plots	BeginAlignedPlots / EndAlignedPlots
with_colormap	PushColormap / PopColormap
with_style_color	PushStyleColor / PopStyleColor
with_style_var (float / int / float2)	PushStyleVar / PopStyleVar
with_plot_clip_rect	PushPlotClipRect / PopPlotClipRect
with_legend_popup	BeginLegendPopup / EndLegendPopup
with_drag_drop_source_item / _plot / _axis	BeginDragDropSource* / EndDragDropSource
with_drag_drop_target_plot / _axis / _legend	BeginDragDropTarget* / EndDragDropTarget

Same arity-overload style as the existing with_plot/with_subplots (gen2 binds a trailing block to the slot after the last explicit arg, so optional args become overloads, not defaults). Push/Pop scopes run the body unconditionally and always Pop; Begin/End scopes run the body iff Begin returned true.

Deliberately out of scope

• Items / styling / coord / sample_colormap — raw-callable, no wrapper needed (the point above).
• Snapshot / playwright telemetry — v1's with_plot has no snapshot hook by design; that's a v2 (imgui_implot_boost_v2) concern.

Testing

tests/integration/test_v1_scopes.das — a headless in-process smoke. v1 has no snapshot to query, so it nests every new scope and passes iff it renders crash-free (an unbalanced Push/Pop or a missed End would trip an ImGui assert). Full integration suite 13/13 green locally.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR expands the v1 “thin” ImPlot wrapper module (imgui_implot_boost) by adding RAII-style scope helpers for the remaining paired ImPlot APIs (Begin/End and Push/Pop) so callers can’t accidentally skip required End*/Pop* calls. It also adds a headless integration smoke test that exercises all new scopes to catch imbalance asserts.

Changes:

• Add v1 scope wrappers for BeginAlignedPlots/EndAlignedPlots, Push*/Pop* style scopes, legend popup, and plot drag/drop source/target scopes.
• Add a headless integration smoke test that nests all new scopes and passes if it renders crash-free for several frames.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
daslib/implot_boost.das	Adds the new v1 RAII scope wrappers for remaining paired ImPlot APIs.
tests/integration/test_v1_scopes.das	New headless smoke test that exercises all newly added v1 scopes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[borisbat]

Addressed all 6 in 9a233a1 — dropped the redundant explicit literals (vertical=true, expand=0, mouse_button=1, flags=0) and let the native default apply.

Verified the premise first: the implot binding does carry scalar C++ defaults (bool/int/float), so BeginAlignedPlots(group_id) / PushPlotClipRect() / BeginLegendPopup(label_id) / BeginDragDropSource*(…) compile and are equivalent. Note it does not carry struct defaults — BeginPlot("t") fails with "missing argument size" (its default is ImVec2(-1,0)), which is why with_plot/with_subplots keep passing the size explicitly. Smoke (test_v1_scopes.das) still renders crash-free.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.