recording: add the [Del] keycap HUD to the delete_and_select tutorial#30
Merged
Merged
Conversation
Per the keyboard-helper-on-every-keyed-gesture intent, delete_and_select now enables imgui_key_hud (show_modifiers=false - Delete is a plain key, not a chord; keycap_fade_s=2.5 so [Del] lingers through the voice). Delete now fires partway into its voice line (say_begin + lead) so the keycap pops as the line names it, matching the clipboard tutorial's chord timing. The click+Delete self-verification (record_check_value + record_check_rendered) is unchanged and still passes. The [Del] glyph rides borisbat/dasImgui#162 (the HUD glyph table didn't map the editing-key cluster); the committed .mp4 is baked with that fix, and the driver compiles against dasImgui master regardless (keycap_fade_s is already in #161). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the delete_and_select integration recording driver to display an on-screen [Del] keycap (via imgui_key_hud) when the Delete key is fired, and aligns the keypress timing so the HUD appears while the voice line references the action—matching the existing treatment used in the clipboard tutorial.
Changes:
- Enable
imgui_key_hudfor the recording withshow_modifiers=falseand a longerkeycap_fade_slinger. - Change the Delete “beat” to start the voice line with
say_begin, fire Delete partway into the dwell, then sleep the remainder.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the keyboard-helper-on-every-keyed-gesture treatment (started with the clipboard tutorial's Ctrl+D/C/V chords in #27) to the one merged tutorial that presses a key: delete_and_select (the Delete key).
imgui_key_hudwithshow_modifiers=false(Delete is a plain key, not a chord) andkeycap_fade_s=2.5so the[Del]keycap lingers through the voice line.say_begin+ lead), so the keycap pops as the line names it — same timing as clipboard's chords.record_check_value+record_check_renderedon the node and both links) is unchanged and still passes (ok=true, dropped=0).Dependency
The
[Del]glyph rides borisbat/dasImgui#162 — the HUD glyph table mapped letters/modifiers/arrows but not the editing-key cluster, so Delete fired no keycap. The committed.mp4is baked with that fix (recorded locally), and the driver compiles against dasImgui master regardless (keycap_fade_sis already in the merged #161; an unmapped glyph just means no keycap, not a compile error). So this is mergeable independently — a future re-record needs #162 in for the keycap to reappear.🤖 Generated with Claude Code