Write the container readback rule next to the data it applies to - #434
Merged
Conversation
Comment only; no behaviour change. The endpoint already separates "could not read" from "read an unstamped image", and my own shorthand for it undid that separation one layer up: I wrote "before the rollout -> stamped:false (old image)", which is true only when the container answered healthily. Three cases produce a falsy stamp and only one of them is a statement about which image is serving: ok:true status:200 stamped:false -> the old image is serving ok:false status:5xx stamped:false -> answered but unhealthy; NOT MEASURED (unreachable container throws, so no stamped field exists at all) Caught by Sentinel on the shorthand rather than on the code, which is the point: the next person reads the summary, not the implementation, so the qualifier has to live where the fields are. `stamped:true` gets no matching qualifier, deliberately. The running image has no code emitting `build`, so a true cannot come from anywhere but a rebuilt image. The asymmetry is correct and should not be evened out for tidiness. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment only. No behaviour change. 16 added lines in one file.
/api/admin/container/buildalready separates could not read from read an unstampedimage. My shorthand for it undid that separation one layer up — I wrote "before the
rollout →
stamped:false(old image)", which holds only when the container answeredhealthily.
ok:truestatus:200stamped:falseok:falsestatus:5xxstamped:falsestampedfield at allOnly the first line is a statement about which image is up. Everything else is "not
measured".
Caught by @sentinel on the shorthand rather than on the code, which is exactly the
reason for this PR: the next person reads the summary, not the implementation, so the
qualifier has to live where the fields are.
stamped:truegets no matching qualifier, deliberately — the running image has no codethat emits
build, so a true cannot come from anywhere but a rebuilt image. Theasymmetry is correct and should not be evened out for tidiness.
Verification
tsc --noEmit: 0 errors