Conversation
- the buttons look to be sunken in slightly in Windows XP itself, do that here - this will help me with my Hydrogen Framework too. thanks!
botoxparty
requested changes
Nov 25, 2020
Owner
botoxparty
left a comment
botoxparty
left a comment
There was a problem hiding this comment.
Hey!
This is great thanks for your attention to detail :) That's what this project is all about.
Did you want to add it to the hover state also and i'll merge it in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After zooming in on the original XP.css, I found the buttons to not have the ‘sunken’ appearance as seen in Windows XP itself. I have added it in using the box-shadow property.