remove kubelet ipv4 ACCEPT override#833
Open
rpkelly wants to merge 7 commits intobottlerocket-os:developfrom
Open
remove kubelet ipv4 ACCEPT override#833rpkelly wants to merge 7 commits intobottlerocket-os:developfrom
rpkelly wants to merge 7 commits intobottlerocket-os:developfrom
Conversation
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
Contributor
|
Please squash this together into one commit that explains (at length) why the change is being made and why it's safe now (with citations) when presumably it wasn't in the past. It's not obvious to me that it's going to be compatible with deployed (i.e., not necessarily latest) versions of the various CNI solutions: aws-vpc, Cilium, Calico. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #540
Description of changes:
Removing
FORWARD ACCEPToverride of iptables for kubernetes variants.Testing done:
Built k8s 1.34 and ran k8s e2e tests on ipv4 cluster
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.