Skip to content

chore: disable default snapshots in chromatic #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjuanitas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: disable default snapshots in chromatic #4785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const preview: Preview = {
cropToViewport: true,
delay: 500,
diffThreshold: 0.1,
disableSnapshot: true,
modes: {
specific: {
viewport: {
Expand Down
3 changes: 0 additions & 3 deletions src/components/time/ReadableTime.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,5 @@ export default {
component: ReadableTime,
parameters: {
notes,
chromatic: {
disableSnapshot: true,
},
},
};
5 changes: 5 additions & 0 deletions src/elements/common/stories/__tests__/PreviewDialog-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,9 @@ export default {
args: {
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
3 changes: 3 additions & 0 deletions src/elements/content-explorer/stories/tests/ContentExplorer-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,9 @@ export default {
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: false,
},
msw: {
handlers: defaultHandlers,
},
Expand Down
5 changes: 5 additions & 0 deletions src/elements/content-explorer/stories/tests/DeleteConfirmationDialog-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,9 @@ export const deleteDialogIsLoading = {
export default {
title: 'Elements/ContentExplorer/tests/DeleteConfirmationDialog/visual',
component: DeleteConfirmationDialog,
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
3 changes: 3 additions & 0 deletions src/elements/content-explorer/stories/tests/MetadataView-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,9 @@ const meta: Meta<typeof ContentExplorer> = {
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: false,
},
msw: {
handlers: [
// Note that the Metadata API backend normally handles the sorting. The mocks below simulate the sorting for specific cases, but may not 100% accurately reflect the backend behavior.
Expand Down
5 changes: 5 additions & 0 deletions src/elements/content-explorer/stories/tests/RenameDialog-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,9 @@ export const renameDialogNameTooLongError = {
export default {
title: 'Elements/ContentExplorer/tests/RenameDialog/visual',
component: RenameDialog,
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
5 changes: 5 additions & 0 deletions src/elements/content-explorer/stories/tests/ShareDialog-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,9 @@ export const shareDialogShareAccessSelect = {
export default {
title: 'Elements/ContentExplorer/tests/ShareDialog/visual',
component: ShareDialog,
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
3 changes: 3 additions & 0 deletions src/elements/content-picker/stories/tests/ContentPicker-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ export default {
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: false,
},
msw: {
handlers: [
http.get(`${DEFAULT_HOSTNAME_API}/2.0/folders/69083462919`, () => {
Expand Down
5 changes: 0 additions & 5 deletions src/elements/content-preview/stories/ContentPreview.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,4 @@ export default {
hasHeader: true,
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: true,
},
},
};
5 changes: 0 additions & 5 deletions src/elements/content-preview/stories/tests/ContentPreview-e2e.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,4 @@ export default {
hasHeader: true,
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: true,
},
},
};
5 changes: 5 additions & 0 deletions src/elements/content-preview/stories/tests/ContentPreview-metadata-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,9 @@ export default {
},
},
},
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
1 change: 1 addition & 0 deletions src/elements/content-preview/stories/tests/ContentPreview-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ export default {
},
parameters: {
chromatic: {
disableSnapshot: false,
ignoreSelectors: ['[class^="bp_avatar_module_avatar--"] > [class^="bp_avatar_module_text--"]'],
},
msw: {
Expand Down
5 changes: 0 additions & 5 deletions src/elements/content-sharing/stories/ContentSharing.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,4 @@ export default {
control: { type: 'select' },
},
},
parameters: {
chromatic: {
disableSnapshot: true,
},
},
};
5 changes: 0 additions & 5 deletions src/elements/content-sharing/stories/ContentSharingV2.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,4 @@ export default {
control: { type: 'select' },
},
},
parameters: {
chromatic: {
disableSnapshot: true,
},
},
};
5 changes: 5 additions & 0 deletions src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,9 @@ export const withCollaborators = {
export default {
title: 'Elements/ContentSharingV2/tests/visual-regression-tests',
component: ContentSharingV2Template,
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
7 changes: 6 additions & 1 deletion src/elements/content-sidebar/stories/tests/BoxAISidebar-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ export const basic: StoryObj<typeof BoxAISidebar> = {
},
};

const meta: Meta<typeof ContentSidebar> & { parameters: { msw: { handlers: HttpHandler[] } } } = {
const meta: Meta<typeof ContentSidebar> & {
parameters: { chromatic: { disableSnapshot: boolean }; msw: { handlers: HttpHandler[] } };
} = {
title: 'Elements/ContentSidebar/BoxAISidebar/tests/visual-regression-tests',
component: ContentSidebar,
args: {
Expand Down Expand Up @@ -78,6 +80,9 @@ const meta: Meta<typeof ContentSidebar> & { parameters: { msw: { handlers: HttpH
},
},
parameters: {
chromatic: {
disableSnapshot: false,
},
msw: {
handlers: [
http.get(mockUserRequest.url, () => {
Expand Down
5 changes: 5 additions & 0 deletions src/elements/content-sidebar/stories/tests/ContentSidebar-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ export default {
hasVersions: true,
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};

// Basic
Expand Down
7 changes: 6 additions & 1 deletion src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,9 @@ export const EditSinglelevelTaxonomy: StoryObj<typeof MetadataSidebarRedesign> =
},
};

const meta: Meta<typeof ContentSidebar> & { parameters: { msw: { handlers: HttpHandler[] } } } = {
const meta: Meta<typeof ContentSidebar> & {
parameters: { chromatic: { disableSnapshot: boolean }; msw: { handlers: HttpHandler[] } };
} = {
title: 'Elements/ContentSidebar/MetadataSidebarRedesign/tests/visual-regression-tests',
component: ContentSidebar,
args: {
Expand All @@ -956,6 +958,9 @@ const meta: Meta<typeof ContentSidebar> & { parameters: { msw: { handlers: HttpH
logger: mockLogger,
},
parameters: {
chromatic: {
disableSnapshot: false,
},
msw: {
handlers: defaultMockHandlers,
},
Expand Down
3 changes: 3 additions & 0 deletions src/elements/content-sidebar/stories/tests/TaskModalV2-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ const meta: Meta<typeof InteractiveTaskModal> = {
title: 'Elements/ContentSidebar/TaskModalV2/tests/visual-regression-tests',
component: InteractiveTaskModal,
parameters: {
chromatic: {
disableSnapshot: false,
},
docs: { story: { iframeHeight: 640, inline: false } },
},
};
Expand Down
3 changes: 3 additions & 0 deletions src/elements/content-uploader/stories/tests/ContentUploader-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ export default {
token: global.TOKEN,
},
parameters: {
chromatic: {
disableSnapshot: false,
},
msw: {
handlers: [
http.options(`${DEFAULT_HOSTNAME_API}/2.0/files/content`, () => {
Expand Down
5 changes: 5 additions & 0 deletions src/features/content-insights/stories/tests/ContentInsightsSummary-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,9 @@ export const WithNegativeTrendRedesign = {
export default {
title: 'Features/ContentInsights/tests/visual-regression-tests',
component: ContentInsightsSummary as React.ComponentType,
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
5 changes: 5 additions & 0 deletions src/features/metadata-instance-editor/stories/tests/CascadePolicy-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,9 @@ export { EnabledCascadePolicyOptionsFieldsOnly, DisabledCascadePolicyOptionsFiel
export default {
title: 'Features/Metadata Instance Editor/CascadePolicy/Visual',
component: CascadePolicy,
parameters: {
chromatic: {
disableSnapshot: false,
},
},
};
3 changes: 0 additions & 3 deletions src/features/security-cloud-game/stories/SecurityCloudGame.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,5 @@ export default {
component: SecurityCloudGame,
parameters: {
notes,
chromatic: {
disableSnapshot: true,
},
},
};
Loading