Install Salt using Salt bootstrap script#182
Install Salt using Salt bootstrap script#182rominf wants to merge 1 commit intoboxcutter:masterfrom rominf:salt
Conversation
Official bootstrap script written in Powershell is used. `CM_OPTIONS` are passed as arguments (see `README.md`). PS: old way of installing Salt was limited and no longer works.
|
I'll look at getting this merged after the holidays when I have access to my saltstack boxes to test. That ok? |
arizvisa
added
bug
arizvisa
left a comment
arizvisa
left a comment
There was a problem hiding this comment.
Thanks for your PR. Other than the preservation of the CM_VERSION functionality, I think this PR is good-to-go.
|
|
||
| @if errorlevel 1 echo ==^> WARNING: Error %ERRORLEVEL% was returned by: "%SALT_PATH%" /S %SALT_OPTIONS% | ||
| ver>nul | ||
| powershell "%SALT_PATH%" %CM_OPTIONS% |
There was a problem hiding this comment.
Can we include the -version parameter here wth %CM_VERSION% so that we still expose that capability (to choose version) to users?
I think to avoid needing a conditional for the case of an undefined CM_VERSION, we can use "Latest" but I'll leave that up to you on whether or not you want to use a conditional for calling bootstrap-salt with an undefined CM_VERSION, or a conditional to set CM_VERSION to Latest if it's undefined.
| You can also specify a variable `CM_VERSION`, if supported by the | ||
| configuration management tool, to override the default of `latest`. | ||
| You can also specify a variable `CM_VERSION` for all configuration management | ||
| tools except Salt, to override the default of `latest`. |
There was a problem hiding this comment.
Please see the comment in the review for script/cmtool.bat. I think we might be able to still preserve the functionality of allowing the user to set the salt version via CM_VERSION.
|
Hey @rominf, let me know if you don't have time to incorporate these changes and I'll work on integrating them into your PR. Now that I can help maintain this repo, PRs like this that fix busted functionality are high on my priority list. Thanks for your patience, good sir! |
|
Hey @arizvisa, thanks for asking about the time. Indeed, I'm a little bit busy right now. Feel free to do whatever you want with that PR :) |
|
Ok. I'll see what I can do. |
…which retains usability of the CM_VERSION variable when installing salt.
arizvisa
added
the
PR Superseded
|
I noticed that each of the configuration management tools have a way of passing options to them ( I also added the changes to explicitly specify the These have been consolidated into PR #201. As a result I'm marking this as superseded and will close this PR once #201 gets merged. Thanks for your contribution good sir! |
…which retains usability of the CM_VERSION variable when installing salt.
…ains usability of the CM_VERSION variable when installing salt.
|
Ok. PR #201 with your changes has been merged. Thanks for your contribution! |
…which retains usability of the CM_VERSION variable when installing salt.
2 participants
Official bootstrap script written in Powershell is used.
CM_OPTIONSare passed as arguments (seeREADME.md).PS: the old way of installing Salt was limited and no longer works.