Rename snapshot templates to images and artifacts#663
Open
law-chain-hot wants to merge 1 commit into
Open
Conversation
|
Important Review skippedToo many files! This PR contains 298 files, which is 148 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (298)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why three layers
The old Snapshot name was doing three jobs at once: the user-selected base, the runtime artifact, and the per-runner cached copy. Splitting those responsibilities makes ownership explicit: the control plane owns metadata and defaults, artifact logic owns build/pull/remove work, and each runner owns local cache state. Backup snapshots remain a separate concept.
Migration notes
1780200000000to rename snapshot tables, columns, indexes, enums, and permissions tobox_template,runner_artifact_cache,artifactRef,template, and template permissions.Test plan
NX_DAEMON=false yarn nx run dashboard:buildNX_DAEMON=false yarn nx run api:test --runInBand box-template.service system-templates artifact-ref sandbox-to-box.mapperNX_DAEMON=false yarn nx run api-client:buildNX_DAEMON=false yarn nx run runner-api-client:buildNX_DAEMON=false yarn nx run sdk-typescript:buildgo test ./...inapps/api-client-gogo build ./...inapps/proxygo test ./...andgo build ./...inapps/artifact-registryKnown verification blockers
make build:appsis blocked by current repo/env issues unrelated to this diff: missingVERSION, missingapps/hack/computer-use/build-computer-use-amd64.sh, and Nx resolvingapps/apps/...paths for API/otel builds.sdks/go/libboxlite.a;make dev:goand the pre-push changed-test hook are blocked by uninitialized vendored submodules forlibkrun/e2fsprogs.box-template.controller.specimports modules that hit existingnode-forgeandRequest.usertyping issues; the focused service/utils/system-template/mapping tests pass.