Add now-timestamp parameter to simpleSaveChangeHistory

[pylipp]

https://trello.com/c/sONNWuHc

[Copilot]

Pull request overview

This PR refactors the simpleSaveChangeHistory function to accept a timestamp parameter instead of using SQL's NOW() function directly. This change allows for better control over timestamp generation and ensures consistency when multiple operations need to use the same timestamp.

Changes:

• Modified simpleSaveChangeHistory function signature to accept a $now parameter before the optional $from and $to parameters
• Updated all call sites in the changed regions to generate timestamps using PHP's date('Y-m-d H:i:s') and pass them to the function
• Replaced SQL NOW() calls with parameterized :now placeholders in UPDATE and INSERT queries across multiple files

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
library/lib/tools.php	Updated function signature and SQL query to use parameterized timestamp
library/lib/list.php	Updated listDeleteAction and listUnDeleteAction to generate and pass timestamps
library/functions.php	Updated move_boxes to generate timestamp once per transaction and use it consistently
library/ajax/deleteprofile.php	Updated user deletion to use parameterized timestamp
cron/dailyroutine.php	Updated daily routine deletions to use parameterized timestamp

Comments suppressed due to low confidence (1)

library/lib/list.php:298

• When listUnDeleteAction is called recursively for child records (line 298), each recursive call generates a new timestamp. This means parent and child records will have different timestamps in the history table, even though they're part of the same logical operation. Consider passing the $now timestamp as a parameter through the recursive calls to ensure all related records have consistent timestamps.

    if ($recursive) {
        $childs = db_array('SELECT id FROM '.$table.' WHERE parent_id = :id', ['id' => $id]);
        foreach ($childs as $child) {
            $count += listUnDeleteAction($table, $child['id'], $count, true);

[Copilot]

@pylipp I've opened a new pull request, #815, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

library/lib/list.php:276

• The listUnDeleteAction function generates a new $now timestamp at line 266, but when it recursively calls itself at line 276, it doesn't pass $now as a parameter. This means each recursive call will generate a different timestamp, resulting in inconsistent timestamps between parent and child records. This differs from the pattern used in listDeleteAction (line 230) which correctly passes $now to recursive calls. Consider modifying listUnDeleteAction to accept $now as a parameter and pass it to recursive calls for consistency.

    $now = date('Y-m-d H:i:s');
    $result = db_query('UPDATE '.$table.' SET deleted = '.($null ? 'NULL' : '0').', modified = :now, modified_by = :user_id WHERE id = :id', ['now' => $now, 'id' => $id, 'user_id' => $_SESSION['user']['id']]);
    $count += $result->rowCount();
    if ($result->rowCount()) {
        simpleSaveChangeHistory($table, $id, 'Record recovered', $now);
    }

    if ($recursive) {
        $childs = db_array('SELECT id FROM '.$table.' WHERE parent_id = :id', ['id' => $id]);
        foreach ($childs as $child) {
            $count += listUnDeleteAction($table, $child['id'], $count, true);

[Copilot]

When simpleSaveChangeHistory is called without the $from and $to parameters (using the default empty arrays), accessing $from['int'], $from['float'], $to['int'], and $to['float'] at line 298 will trigger "Undefined array key" warnings in PHP 8+. Consider adding null coalescing operators to handle these cases gracefully, such as $from['int'] ?? null instead of $from['int']. This affects all calls to this function that don't provide these parameters, including the new calls added in this PR.