Skip to content

Fix deleteprofile #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaGuesto merged 4 commits into from
Mar 23, 2026
Merged

Fix deleteprofile #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2941495
Fix deleteprofile
pylipp Feb 6, 2026
2e2b9bb
Run simpleSaveChangeHistory in transaction
pylipp Feb 6, 2026
7a29ff5
Correct log message
pylipp Feb 6, 2026
d616b0c
Set modified and modified_by
pylipp Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions assets/js/custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,9 +631,6 @@ $(".delete-user").on("click", function (e) {
$.ajax({
type: "post",
url: "ajax.php?file=deleteprofile",
data: {
cms_user_id: el.data("id"),
},
dataType: "json",
success: function (result) {
AjaxCheckSuccess(result);
Expand Down
7 changes: 4 additions & 3 deletions library/ajax/deleteprofile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
<?php

db_transaction(function () {
$user_id = $_SESSION['user']['id'];
Copy link
Copy Markdown
Member

@HaGuesto HaGuesto Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy how unsafe that has been before

// Only append .deleted suffix if the email doesn't already have it
// This prevents double-deletion if the query is somehow executed twice
// Pattern checks for .deleted.<digits> after the @ symbol (e.g., user@domain.com.deleted.123)
db_query('UPDATE cms_users SET deleted = NOW(), email = CONCAT(email,".deleted.",id) WHERE id = :id AND (NOT deleted OR deleted IS NULL) AND email NOT REGEXP "@.*\.deleted\.[0-9]+$"', ['id' => $_POST['cms_user_id']]);
updateAuth0UserFromDb($_POST['cms_user_id']);
db_query('UPDATE cms_users SET modified = NOW(), modified_by = :id, deleted = NOW(), email = CONCAT(email,".deleted.",id) WHERE id = :id AND (NOT deleted OR deleted IS NULL) AND email NOT REGEXP "@.*\.deleted\.[0-9]+$"', ['id' => $user_id]);
updateAuth0UserFromDb($user_id);
simpleSaveChangeHistory('cms_users', $user_id, 'Record deleted');
});

simpleSaveChangeHistory('cms_users', $_POST['cms_user_id'], 'Record deleted without undelete');
// when a user deactive its account we need to ensure that user logged out immediately and then redirected to Auth0 login page
global $settings;
logout();
Expand Down