feat: add F# string literals so (* inside a string is not a comment opener - #737
Open
YuriNachos wants to merge 1 commit into
Open
feat: add F# string literals so (* inside a string is not a comment opener#737YuriNachos wants to merge 1 commit into
YuriNachos wants to merge 1 commit into
Conversation
…pener F# declared (* *) as multi-line comments but left quotes empty, so a (* inside any string opened a phantom block comment that swallowed the following code lines. Append F#'s three string-literal forms to quotes (regular, verbatim @", triple-quoted """) and regenerate the compiled-in database. Add TestCountStatsFSharpStringHidesBlockComment proving a (* inside a string no longer eats the following code lines. Co-Authored-By: Claude <noreply@anthropic.com>
pr-insights
Bot
added
L/complexity
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scc mis-counting F# files where a
(*inside a string literal opens a phantom multi-line comment.Summary
languages.json(quoteswas empty): regular"…"(escaped), verbatim@"…"(no escape), and triple-quoted"""…"""(F# 5+, no escape, may span lines).processor/constants.goandLANGUAGES.mdviago generate.TestCountStatsFSharpStringHidesBlockCommentproving a(*inside a string no longer eats the following code lines.Root Cause
F# declares
(* … *)as a multi-line comment but had an emptyquotesarray. scc's scanner only ignores comment delimiters while inside a declared string, so a(*inside any"…"string opened a real block comment that consumed every subsequent line as a comment until EOF or a stray*). A 5-line fixture reportedCode=1, Comment=4instead ofCode=4, Comment=1.F# string syntax per the F# language reference: regular
"…", verbatim@"…", and triple-quoted"""…""". Modelled on the existing C#@"…"and Boo/Cangjie"""…"""entries.Validation
go generate(regenerates constants.go + LANGUAGES.md, no diff)go build ./...go test -race ./...go test -run TestCountStatsFSharpStringHidesBlockComment ./processor/ -v(red on master, green after fix)Code=4, Comment=1I licence this contribution under the MIT licence.