Add BGP local-preference test cases for T1 topology#10
Open
bpar9 wants to merge 1 commit into
Open
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Adds
tests/bgp/test_bgp_local_preference.pyimplementing 21 test cases for BGP local-preference functionality on T1 topology, based on the BGP Local-Preference Test Plan.Test cases cover:
17–21. Route reflector scenarios (preservation, setting, best path, multiple clients, client override)
Link to Devin run: https://cisco-demo.devinenterprise.com/sessions/5d7e6751313845458da92a5214eca3b4
Requested by: @bpar9
Type of change
Back port request
Approach
What is the motivation for this PR?
Provide automated test coverage for BGP local-preference attribute behavior, including route-map configuration, best path selection, iBGP/eBGP propagation rules, interaction with other path attributes (AS-path, MED, weight), and route reflector scenarios.
How did you do it?
tests/bgp/test_bgp_local_preference.pysetupfixture gathers topology info (T0/T2 neighbors, ASN, ExaBGP ports, next-hops)cleanupfixture ensures route-map removal after each testHow did you verify/test it?
Any platform specific information?
None - uses standard FRR/vtysh commands
Supported testbed topology if it's a new test case?
T1 topology only (
@pytest.mark.topology('t1'))Human Review Checklist
Reviewers should verify:
http://<ptfip>:<port>withcommandsfield) matches testbed setuppaths,locPrf,bestpath,peerId,aspath) matches FRR version10.100.0.0/24,2001:db8:100::/64,10.200.x.0/24) don't conflict with testbed routesDocumentation
N/A - test code only