Enhance database container process monitoring test for multi-ASIC support#4
Open
bpar9 wants to merge 1 commit into
Open
Enhance database container process monitoring test for multi-ASIC support#4bpar9 wants to merge 1 commit into
bpar9 wants to merge 1 commit into
Conversation
…port - Update get_skip_containers() to support include_database parameter - Enhance get_containers_namespace_ids() for multi-ASIC database handling - Add validate_database_processes_multi_asic() helper function - Create test_database_critical_process_monitoring_multi_asic() test function - Add recover_critical_processes_database fixture for database recovery Co-Authored-By: bhavani@cisco.com <bhavani@cisco.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR enables testing of database container critical processes on multi-ASIC devices. Previously, the database container was always skipped in process monitoring tests (line 527). This change adds support for testing database processes (redis-server) across all ASIC namespaces.
Key changes:
get_skip_containers()to acceptinclude_databaseparameter for conditional database testingget_containers_namespace_ids()with special handling for database container on multi-ASIC devicesvalidate_database_processes_multi_asic()helper to verify database processes across all ASICsrecover_critical_processes_databasefixture for database-specific recoverytest_database_critical_process_monitoring_multi_asic()test functionReviewer focus areas:
database{asic_index}) is correct for multi-ASICip netns execcommand pattern for multi-ASIC namespace operationsType of change
Back port request
Approach
What is the motivation for this PR?
The database container runs Redis processes critical for SONiC's operation. Testing these processes across multiple ASIC namespaces on multi-ASIC devices was not previously supported.
How did you do it?
include_databaseparameter toget_skip_containers()to conditionally include database containerHow did you verify/test it?
flake8 --select=E9,F63,F7,F82)Any platform specific information?
Works on both single-ASIC and multi-ASIC devices.
Supported testbed topology if it's a new test case?
Supports topologies:
any,t1-multi-asic(same as existing tests in this file)Documentation
N/A - Test case enhancement
Link to Devin run: https://cisco-demo.devinenterprise.com/sessions/1854d5db06984a86a9bf5dffdfa23528
Requested by: bhavani@cisco.com (@bpar9)