Add test implementation for BGP aggregate address with BBR awareness#6
Open
bpar9 wants to merge 2 commits into
Open
Add test implementation for BGP aggregate address with BBR awareness#6bpar9 wants to merge 2 commits into
bpar9 wants to merge 2 commits into
Conversation
This commit adds pytest test cases to verify the BGP aggregate address with BBR (Bounce Back Routing) awareness feature as described in the test plan at docs/testplan/BGP-Aggregate-Address.md. Test cases implemented: - test_aggregate_address_parameters_combination: Tests aggregate address add/remove with various parameter combinations (as_set, summary_only, bbr_required) - test_aggregate_address_ipv6: Tests IPv6 aggregate address support - test_bbr_state_change: Tests aggregate address behavior when BBR state changes (enable/disable) - test_bbr_state_change_mixed_addresses: Tests mixed bbr_required settings - test_bgp_container_restart: Tests aggregate address persistence after BGP container restart - test_capacity_stress: Capacity test with 1000 aggregate addresses - test_link_flapping: Tests behavior during interface shutdown/startup - test_aggregate_address_update: Tests updating existing aggregate address The tests validate: - Config DB entries for aggregate addresses - State DB entries showing active/inactive state - BGP running configuration for aggregate addresses - Proper state transitions based on BBR status Co-Authored-By: bhavani@cisco.com <bhavani@cisco.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This commit adds a new testplan document that describes the test cases for the BGP aggregate address with BBR awareness feature. The testplan is independent of the existing BGP-Aggregate-Address.md and provides comprehensive documentation of: - Feature overview and scope - Related DUT CLI commands - Supported topologies (t1, t1-multi-asic) - 8 detailed test cases with steps and expected results - Test implementation details including helper functions and fixtures - Database table references Also updates the test file docstring to reference the new testplan. Co-Authored-By: bhavani@cisco.com <bhavani@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR adds pytest test implementation and a new testplan document for the BGP aggregate address with BBR (Bounce Back Routing) awareness feature.
The test file validates that aggregate addresses can be configured with the
bbr_requiredflag, and that these addresses become active/inactive based on the BBR feature state.Link to Devin run: https://cisco-demo.devinenterprise.com/sessions/71c0f42835ce4a9586a92d30b6615c2c
Requested by: @bpar9
Updates since last revision
docs/testplan/BGP-Aggregate-Address-BBR-Awareness-Test-Plan.mdType of change
Back port request
Approach
What is the motivation for this PR?
Implement automated tests for the BGP aggregate address with BBR awareness feature to ensure proper functionality and prevent regressions.
How did you do it?
Added a new test file
tests/bgp/test_bgp_aggregate_address.pywith the following test cases:as_set,summary_only, andbbr_requiredflags (8 test cases)bbr_requiredsettingsThe tests use GCU (Generic Config Update) to apply configuration changes and validate state across config_db, state_db, and BGP running configuration.
How did you verify/test it?
test_bgp_bbr.pyand other BGP testsImportant for reviewers:
BGP_AGGREGATE_ADDR,BGP_AGGREGATE_ADDR_TABLE) match the actual implementationAny platform specific information?
N/A
Supported testbed topology if it's a new test case?
Documentation
New testplan document added:
docs/testplan/BGP-Aggregate-Address-BBR-Awareness-Test-Plan.md