Open
Conversation
…dy initialized constant STRING' warnings
Owner
|
This looks good. Can you extract the equivalent config finding logic into a separate method, #current_pool is getting kinda busy. |
Author
|
I'm not actually working on the project I was using data_fabric for anymore. This pull request was actually sitting on the parent repo for many months before mperham noticed and recommended I send it over here, which didn't require any dev setup or work. Unfortunately it will probably be a while before I get a chance to work on it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were running into connection limit issues with mysql when using multiple :shard_by values. We're sharding different models differently, but to the same set of shards, so we end up duplicating connections that are the same for all intents and purposes. I made a change that searches through shard_pools looking for an connection to the same DB before creating a new connection. This reduced our number of DB connections by half.
I also added a test for this. In order to ease my life when testing I setup everything with bundler, which I'm hoping you'll pull in as well.
Thanks,
Jason