fix: Tie native bridge monitoring to arm state for DAW-like behavior#721
Merged
braedonsaunders merged 1 commit intoclaude/build-openstudio-app-kgia5from Jan 6, 2026
Conversation
The native bridge's audio monitoring was not checking the track's armed state, causing inconsistent behavior when arming/disarming tracks. In the browser's TrackAudioProcessor, monitoring is properly tied to arm state (shouldMonitor = isArmed && monitoringEnabled). However, the native bridge only checked monitoring_enabled and is_muted, ignoring is_armed. This caused the bug where: 1. Start audio with track armed → audio works 2. Disarm track → audio stops (expected for DAW) 3. Re-arm track → no audio (bug) The fix adds is_armed to the should_monitor check in process_input(), making native bridge monitoring behave like a traditional DAW: - Monitoring requires: armed AND monitoring enabled AND not muted - Disarming a track now properly stops input monitoring - Re-arming restores monitoring as expected
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
braedonsaunders
merged commit 645a64e
into
claude/build-openstudio-app-kgia5
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native bridge's audio monitoring was not checking the track's armed state, causing inconsistent behavior when arming/disarming tracks.
In the browser's TrackAudioProcessor, monitoring is properly tied to arm state (shouldMonitor = isArmed && monitoringEnabled). However, the native bridge only checked monitoring_enabled and is_muted, ignoring is_armed.
This caused the bug where:
The fix adds is_armed to the should_monitor check in process_input(), making native bridge monitoring behave like a traditional DAW: