Syncing from upstream OCA/server-ux (19.0)#1163
Merged
bt-admin merged 3 commits intobrain-tec:19.0from Apr 14, 2026
Merged
Conversation
When base_cancel_confirm adds fields to XML via get_view(), it must also add those fields to the models dictionary. The previous code skipped merging when the model already existed, causing JavaScript errors like: "Missing field string information for the field 'cancel_confirm'" This fix merges the new fields with existing ones instead of skipping them. Closes #1190
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 19.0 #1163 +/- ##
=======================================
Coverage 95.05% 95.05%
=======================================
Files 42 42
Lines 1132 1132
Branches 110 110
=======================================
Hits 1076 1076
Misses 29 29
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot