Add LangSlice to the list of tools built upon BrainGlobe#502
Conversation
alessandrofelder
left a comment
There was a problem hiding this comment.
Thanks @adamltyson
CI failure related to yet another (temporarily, I think/hope) broken link, so maybe we wait with merging until it is back up (otherwise likely that this won't get propagated to the website until the next PR we merge)?
|
That's fine though? IMO we should just merge, and it will propagate to the website at some point (there's no time constraint on this). BTW most of these linkcheck issues are very transient, I've managed to get lots of changed built this week by just re-running the job once or twice. |
I agree it's fine for this case. I worry about us generally getting too used to CI failing for this repo due to (right now I know further runs going to fail again because https://developingmouse.brain-map.org/ is not accessible even manually at the moment) |
Fair point, but I don't think letting unmerged PRs accumulate (and causing merge conflicts) is the way to solve this. |
|
OK - I (reluctantly 😂) agree. I would be less reluctant if neuroinformatics-unit/actions#163 was addressed, because at least it would solve:
|
No description provided.