Skip to content

Add LangSlice to the list of tools built upon BrainGlobe#502

Merged
alessandrofelder merged 1 commit into
mainfrom
langslice
May 22, 2026
Merged

Add LangSlice to the list of tools built upon BrainGlobe#502
alessandrofelder merged 1 commit into
mainfrom
langslice

Conversation

@adamltyson
Copy link
Copy Markdown
Member

No description provided.

@adamltyson adamltyson requested a review from a team May 22, 2026 13:05
Copy link
Copy Markdown
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamltyson

CI failure related to yet another (temporarily, I think/hope) broken link, so maybe we wait with merging until it is back up (otherwise likely that this won't get propagated to the website until the next PR we merge)?

@adamltyson
Copy link
Copy Markdown
Member Author

That's fine though? IMO we should just merge, and it will propagate to the website at some point (there's no time constraint on this).

BTW most of these linkcheck issues are very transient, I've managed to get lots of changed built this week by just re-running the job once or twice.

@alessandrofelder
Copy link
Copy Markdown
Member

alessandrofelder commented May 22, 2026

it will propagate to the website at some point (there's no time constraint on this).

I agree it's fine for this case. I worry about us generally getting too used to CI failing for this repo due to linkcheck that we stop checking for deeper issues, or expect something to be on the website that is actually not, when speaking to a collaborator. Maybe I am being too paranoid?

(right now I know further runs going to fail again because https://developingmouse.brain-map.org/ is not accessible even manually at the moment)

@adamltyson
Copy link
Copy Markdown
Member Author

I worry about us generally getting too used to CI failing for this repo

Fair point, but I don't think letting unmerged PRs accumulate (and causing merge conflicts) is the way to solve this.

@alessandrofelder
Copy link
Copy Markdown
Member

alessandrofelder commented May 22, 2026

OK - I (reluctantly 😂) agree. I would be less reluctant if neuroinformatics-unit/actions#163 was addressed, because at least it would solve:

expect something to be on the website that is actually not,

@alessandrofelder alessandrofelder merged commit 7afacf7 into main May 22, 2026
3 of 4 checks passed
@alessandrofelder alessandrofelder deleted the langslice branch May 22, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants