fix incorrect definition of __all__ in __init__.py file#238
Open
Malviyaaadarsh wants to merge 1 commit into
Open
fix incorrect definition of __all__ in __init__.py file#238Malviyaaadarsh wants to merge 1 commit into
Malviyaaadarsh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
__all__inbrainrender-napari/__init__.pywas defined as a string rather than a list. Defining it as a string does not follow standard conventions and lead to import errors when usingfrom brainrender_napari import *in python shell when i tested in terminal. This is much needed for developers using python shell to interact with napari viewer.Also, the widget classes were not imported at package level, which makes public imports inconsistent.
What does this PR do?
__all__variable to a list of strings.__init__.pyfile.References
None
How has this PR been tested?
Locally verified that widgets imported correctly. Running
from brainrender_napari import *in the python shell works without import errors. Launched and tested napari in the shell usingnapari.Viewer()to ensure plugin behaviour remain the same.Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: