chore(e2e): follow-up fixes for PR #1920 review feedback#1959
Open
Stephen Belanger (Qard) wants to merge 3 commits intomainfrom
Open
chore(e2e): follow-up fixes for PR #1920 review feedback#1959Stephen Belanger (Qard) wants to merge 3 commits intomainfrom
Stephen Belanger (Qard) wants to merge 3 commits intomainfrom
Conversation
- Remove dotenv loading from vitest.setup.ts — mise handles .env loading - Drop the dotenv dev-dependency from e2e/package.json - Simplify test:e2e:record to an inline env-var prefix; delete the record-cassettes.mjs wrapper script that did nothing beyond that - Delete dev-packages/seinfeld/LICENSE (repo-level license applies) - Delete dev-packages/seinfeld/scripts/migrate-from-legacy.mjs — the one-time migration it performed is complete and the file is unreferenced - Clarify the format versioning rationale in seinfeld/src/format/v1.ts - Sort JSON keys when writing cassette files (file-store.ts) so re-recordings produce deterministic diffs and snapshot comparisons are not confused by non-deterministic key insertion order Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…faults - Replace global cassette-filters.mjs registry with per-scenario cassette-filter.mjs files; cassette-preload.mjs now dynamically imports them from the scenario dir - Default redact to 'paranoid' in seinfeld recorder (was opt-in) - Gate provider key placeholder injection on replay mode only (not record/passthrough) - Delete obsolete cassette-filters.mjs and record-cassettes.mjs helper scripts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Luca Forstner (lforst)
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1920 (
feat(e2e): MSW cassette layer for hermetic e2e tests) addressing inline review feedback..envloading; thedotenvdev-dependency and itsvitest.setup.tsusage are removedtest:e2e:record— replaced therecord-cassettes.mjswrapper script with an inline env-var prefix; deleted the now-empty scriptseinfeld/LICENSE— repo-level license applies; per-package copy was redundantseinfeld/scripts/migrate-from-legacy.mjs— one-time migration already run, file is unreferencedseinfeld/src/format/v1.tsfile-store.ts) — makes re-recordings produce deterministic diffs and prevents snapshot comparison failures from non-deterministic key insertion orderredactto'paranoid'in seinfeld recorder — was opt-in; now on by default so cassette files never contain raw credentials by accidentgetProviderKeyPlaceholders()was previously injected in record mode too, which caused confusing "invalid key" errors instead of clear "missing key" errorse2e/helpers/cassette-filters.mjsregistry with per-scenariocassette-filter.mjsfiles;cassette-preload.mjsnow dynamically imports them from the scenario directory, falling back to"default"if absentBRAINTRUST_E2E_CASSETTE_MODE=passthroughin the canary runnerTest plan
pnpm run test:e2e:hermetic— 495 tests, 0 failures)BRAINTRUST_E2E_CASSETTE_MODE=passthroughso live API calls are not intercepted🤖 Generated with Claude Code