fix OpenAI body already red#1969
Merged
Cedric / ViaDézo1er (viadezo1er) merged 4 commits intomainfrom May 8, 2026
Merged
Conversation
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/fix-openai-body-already-red
branch
from
878e709 to
7b24653
Compare
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/fix-openai-body-already-red
branch
from
4875bad to
8ebbac5
Compare
Contributor
Author
|
CI e2e fails due to invalid COPILOT_API_KEY/BRAINTRUST_E2E_MODEL_BASE_URL in github secrets. |
Stephen Belanger (Qard)
approved these changes
May 8, 2026
Contributor
Stephen Belanger (Qard)
left a comment
Stephen Belanger (Qard)
left a comment
There was a problem hiding this comment.
This feels a bit hack-ish, but the APIPromise stuff has been a pain...I'm not sure if there's a non-hacky solution. 😐
Cedric / ViaDézo1er (viadezo1er)
deleted the
cedric/fix-openai-body-already-red
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI's
chat.completions.parse()callscreate()._thenUnwrap(...), which produces twoAPIPromiseinstances sharing the same responsePromise.Our SDK called
.then()on each of them, triggered aparseResponse, which callsresponse.json()on the HTTP response body. However aResponsebody can only be read once.Might fix a customer issue https://braintrustdata.slack.com/archives/C0B27UX9UDR/p1778223683547239