google_genai and pydantic init_logger no longer unconditionally called during auto_instrument#169
Closed
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit intomainfrom
Conversation
…ing auto_instrument
Cedric / ViaDézo1er (viadezo1er)
linked an issue
Cedric / ViaDézo1er (viadezo1er)
requested a review
from Abhijeet Prasad (AbhiPrasad)
This was referenced Mar 30, 2026
Member
|
resolved by #182 |
Abhijeet Prasad (AbhiPrasad)
deleted the
cedric/168-google_genai-init_logger-unconditionally-called-during-auto_instrument
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #168
5 times (plus the import).
init_logger was called when there was no active span without checking for a logger.