fix(anthropic): log stop reason in span output#185
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoApr 1, 2026
Conversation
Include Anthropic message model, stop_reason, and stop_sequence in the logged span output so spans preserve the model stop metadata returned by the API. Add a focused regression test for _log_message_to_span and extend an existing VCR-backed integration test to assert the new fields. Closes #175
Abhijeet Prasad (AbhiPrasad)
requested a review
from Cedric / ViaDézo1er (viadezo1er)
Contributor
|
Drop into this review session: No serious bugs or issues found 🎉 |
Luca Forstner (lforst)
approved these changes
Apr 1, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi-fix-175-anthropic-stop-reason
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include Anthropic message
model,stop_reason, andstop_sequencein the logged span output so spans preserve the model stop metadata returned by the API. Add a focused regression test for_log_message_to_spanand extend an existing VCR-backed integration test to assert the new fields.Closes #175