include sandbox runtime in list request#227
Conversation
|
Failed: Failed to send input to session |
|
Drop into this review session: Code Review — PR #227: include sandbox runtime in list requestSummary: One-liner that adds Change is correct and well-placed
# Already used in function_data at line 134:
"runtime_context": runtime_context, # {"runtime": "python", "version": "3.13"}
# Now also sent to sandbox-list (the new line):
"runtime_context": runtime_context,Makes sense semantically: the list endpoint needs to know which Python version the caller is running to return compatible evaluators. Cassettes are stale but won't break testsThe three VCR cassettes in # cassettes/test_register_sandbox_single_evaluator.yaml, line 75–77
body: '{"sandbox_spec": {"provider": "modal", "snapshot_ref": "im-icRxmsk1Sz9XPP2f8OblVU"},
"entrypoints": [...], "project_id": "..."}'After this PR the actual request body will also include That said, the cassettes no longer accurately document what the real request looks like. It would be worth re-recording them so future developers can see the full request shape: cd py
BRAINTRUST_CLAUDE_AGENT_SDK_RECORD_MODE=all nox -s test_core -- src/braintrust/test_sandbox.py(or the equivalent This is a minor nit — not a blocker. No new test coverage for the new fieldThere's no assertion that VerdictApprove. The change is minimal, correct, and consistent with how |
In order to add support for python based sandboxes we need to pass the runtime into the list request. The change is backwards compatible and the value will be stripped on out of date data plane versions.