enhancement - add an optional exporter injection point to BraintrustSpanProcessor#42
Closed
colinbennettbrain wants to merge 4 commits intomainfrom
Closed
enhancement - add an optional exporter injection point to BraintrustSpanProcessor#42colinbennettbrain wants to merge 4 commits intomainfrom
colinbennettbrain wants to merge 4 commits intomainfrom
Conversation
- Implemented _on_ending method in AISpanProcessor and BraintrustSpanProcessor to forward pre-end hooks. - Added a helper function _forward_on_ending to handle compatibility with different OpenTelemetry SDK versions. - Updated tests to verify the presence and functionality of the new _on_ending method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exporterparameter to theadd_braintrust_span_processorfunction and theBraintrustSpanProcessorclass to allow injection of custom OpenTelemetry exporters.InMemorySpanExporter.