Skip to content

chore: use Python 3.14 for local development #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into from
Mar 9, 2026
Merged

chore: use Python 3.14 for local development #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/adk-py-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_call:
inputs:
python-version:
required: true
required: false
type: string

jobs:
Expand All @@ -20,25 +20,25 @@ jobs:
with:
cache: true
experimental: true
install_args: python@${{ inputs.python-version }} uv
install_args: uv

- name: Install deprecated package compatibility dependencies
working-directory: integrations/adk-py
run: |
mise exec python@${{ inputs.python-version }} -- uv sync
mise exec -- uv sync

- name: Lint deprecated compatibility package
working-directory: integrations/adk-py
run: |
mise exec python@${{ inputs.python-version }} -- uv run ruff check $(git ls-files '*.py' | grep -v 'examples/')
mise exec -- uv run ruff check $(git ls-files '*.py' | grep -v 'examples/')

- name: Run deprecated compatibility tests
working-directory: integrations/adk-py
run: |
mise exec python@${{ inputs.python-version }} -- uv run pytest src/tests/test_reexports.py
mise exec -- uv run pytest src/tests/test_reexports.py

- name: Test deprecated package import
working-directory: integrations/adk-py
run: |
mise exec python@${{ inputs.python-version }} -- uv run python -c "import braintrust_adk; print('braintrust_adk imported successfully')"
mise exec python@${{ inputs.python-version }} -- uv run python -c "from braintrust_adk import setup_braintrust; print('setup_braintrust imported successfully')"
mise exec -- uv run python -c "import braintrust_adk; print('braintrust_adk imported successfully')"
mise exec -- uv run python -c "from braintrust_adk import setup_braintrust; print('setup_braintrust imported successfully')"
3 changes: 1 addition & 2 deletions .github/workflows/publish-py-sdk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,9 @@ jobs:
with:
cache: true
experimental: true
install_args: python@3.13
- name: Build and verify
run: |
mise exec python@3.13 -- make -C py install-dev verify-build
mise exec -- make -C py install-dev verify-build
- name: Upload build artifacts
uses: actions/upload-artifact@v4
with:
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/py.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ jobs:

adk-py:
uses: ./.github/workflows/adk-py-test.yaml
with:
python-version: "3.13"

langchain-py:
uses: ./.github/workflows/langchain-py-test.yaml
Expand All @@ -75,10 +73,9 @@ jobs:
with:
cache: true
experimental: true
install_args: python@3.13
- name: Install build dependencies and build wheel
run: |
mise exec python@3.13 -- make -C py install-build-deps build
mise exec -- make -C py install-build-deps build
- name: Upload wheel as artifact
uses: actions/upload-artifact@v4
with:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/test-publish-py-sdk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@ jobs:
with:
cache: true
experimental: true
install_args: python@3.13
- name: Install build dependencies
run: |
mise exec python@3.13 -- make -C py install-dev
mise exec -- make -C py install-dev
- name: Build and verify
run: |
mise exec python@3.13 -- make -C py verify-build
mise exec -- make -C py verify-build
- name: Get version from built wheel
id: get_version
run: |
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
python 3.13.3
python 3.14.3
Copy link
Copy Markdown
Contributor

@ibolmo Olmo Maldonado (ibolmo) Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suppose it's possible for our ci to catch regressions, but til we were doing 3.13. i was expecting we would have 3.11 to avoid leaking 3.12+ unique features in the code

Copy link
Copy Markdown
Member Author

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is fair, but I think our nox setup is good enough that we should catch older python versions. Testing on latest just helps make sure we can have the fastest/most modern dev env for things moving forward. I'll keep an eye on the PRs though, we can change this is we notice things sneaking in.

pre-commit 4.2.0
uv 0.7.8