chore: Update formatting and linting#85
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
Cedric / ViaDézo1er (viadezo1er)
requested a review
from Abhijeet Prasad (AbhiPrasad)
Remove unused isort, flake8, black config files and import/dependencies Remove .prettierignore (JS config in python repo) Add unused isort config to ruff check config Add ruff format step in pre-commit
Done with the updated make fixup
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/ruff-precommit-not-formatting
branch
from
da1787d to
a2d73de
Compare
Contributor
Author
|
astral-sh/ruff#970 Not all pylint error rules are implemented so ruff can't replace everything pylint does at the moment, especially considering we use pylint's detection of E0401 (not yet implemented in ruff) as indicated by this comment in py/noxfile.py:296 |
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 17, 2026
Abhijeet Prasad (AbhiPrasad)
changed the title
Abhijeet Prasad (AbhiPrasad)
deleted the
cedric/ruff-precommit-not-formatting
branch
Member
|
merged in your PR so we can deal with merge conflicts in other prs more easily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update formatters and linters
Remove unused isort, flake8, black config files and import/dependencies
Remove .prettierignore (JS config in python repo)
Add unused isort config to ruff check config
Add ruff format step in pre-commit
The first commit has the config file changes the second commit is just a
make fixup.So to review the PR I highly recommend looking at the first commit, and only afterward briefly look at the second commit.
Pylint role is unchanged. Maybe it should also be updated? It would makemake (py)lintwould be much faster.Pylint can't be replaced by ruff as of now.