Feature gating the eval module in order to allow for cross-platform builds#28
Draft
Alex Jean-Baptiste (justcodebruh) wants to merge 2 commits intomainfrom
Draft
Feature gating the eval module in order to allow for cross-platform builds#28Alex Jean-Baptiste (justcodebruh) wants to merge 2 commits intomainfrom
Alex Jean-Baptiste (justcodebruh) wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current work in the evals module is unix native.
Since we're not exposing the feature for windows builds of the cli currently i figure this is an easy update and later reversion once bt eval for windows is live.
bt cli windows builds fail due to this lack of feature gating, blocking a canary release in general based on our current build rules:
error from a failing build in a downstream PR for braintrustdata/bt: