add span_parents to span components format#42
Merged
Ken Jiang (knjiang) merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
Ken Jiang (knjiang)
requested review from
Abhijeet Prasad (AbhiPrasad),
Stephen Belanger (Qard) and
Manu Goyal (manugoyal)
Member
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
Wait it's a thing that spans can have multiple parents? I thought it was a 1 to N relationship (parent -> children).
Stephen Belanger (Qard)
approved these changes
Apr 15, 2026
We originally designed it that way in case we wanted to support a DAG-like span structure. But we have never ended up needing it. |
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional
span_parentssupport to exported Rust SDKSpanComponentsand uses it inupdate_span()/update_span_with_credentials()when materializing logs rows.Previously, exported span components could not carry parentage, so
update_span()andupdate_span_with_credentials()always omitted span_parents even when the originating span had it. With this change, exported spans can preserve parentage end to end while remaining backward-compatible for callers that do not send the field.